Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt cluster connect command with 1.0 api #437

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.75524% with 158 lines in your changes missing coverage. Please review.

Project coverage is 43.38%. Comparing base (0657641) to head (27a02ae).

Files with missing lines Patch % Lines
pkg/cmd/cluster/connect.go 50.64% 103 Missing and 11 partials ⚠️
pkg/cluster/helper.go 0.00% 36 Missing ⚠️
pkg/testing/fake.go 57.14% 6 Missing ⚠️
pkg/cluster/cluster_chart.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   44.89%   43.38%   -1.51%     
==========================================
  Files         157      174      +17     
  Lines       23000    24493    +1493     
==========================================
+ Hits        10325    10627     +302     
- Misses      11443    12635    +1192     
+ Partials     1232     1231       -1     
Flag Coverage Δ
unittests 43.38% <44.75%> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyelei wangyelei merged commit 55f8f45 into main Sep 3, 2024
16 checks passed
@wangyelei wangyelei deleted the feature/remove_cli branch September 3, 2024 02:35
@github-actions github-actions bot added this to the Release 0.9.1 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] weaken the kbcli cluster connect and only support the example
3 participants