-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: imporve cluster register and addon #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yipeng1030
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf and
1aal
as code owners
September 20, 2024 07:21
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 43.39% 43.54% +0.14%
==========================================
Files 174 174
Lines 24500 24710 +210
==========================================
+ Hits 10632 10760 +128
- Misses 12637 12707 +70
- Partials 1231 1243 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldming
reviewed
Sep 24, 2024
github-actions
bot
added
size/XXL
Denotes a PR that changes 1000+ lines.
and removed
size/XL
Denotes a PR that changes 500-999 lines.
labels
Sep 24, 2024
yipeng1030
force-pushed
the
feature/create_cluster_adapt_new_API
branch
from
September 24, 2024 09:16
4e9ba0c
to
2442d5b
Compare
github-actions
bot
added
size/XL
Denotes a PR that changes 500-999 lines.
and removed
size/XXL
Denotes a PR that changes 1000+ lines.
labels
Sep 24, 2024
ldming
approved these changes
Sep 24, 2024
ldming
approved these changes
Sep 25, 2024
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly fixed: #420
what's changed: