Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: imporve cluster register and addon #442

Merged
merged 21 commits into from
Sep 25, 2024

Conversation

yipeng1030
Copy link
Contributor

partly fixed: #420

what's changed:

  1. Cluster register supports overriding the built-in chart, pulling by helm repo + engine + version, and validating schema standards.
  2. Addon install and search support specifying a local path.
  3. Addon install, enable, and upgrade support register the chart at the same time.
  4. Addon uninstall also deletes the corresponding chart.
  5. Addon search supports searching for all addons (including those not installed).

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 46.34921% with 169 lines in your changes missing coverage. Please review.

Project coverage is 43.54%. Comparing base (55f8f45) to head (1f1ab2e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cluster/external_charts.go 17.85% 46 Missing ⚠️
pkg/cmd/addon/util.go 32.20% 40 Missing ⚠️
pkg/cmd/cluster/register.go 57.35% 19 Missing and 10 partials ⚠️
pkg/cmd/addon/search.go 76.00% 13 Missing and 5 partials ⚠️
pkg/util/helm/helm.go 0.00% 16 Missing ⚠️
pkg/cmd/addon/install.go 54.83% 11 Missing and 3 partials ⚠️
pkg/cmd/addon/upgrade.go 50.00% 3 Missing ⚠️
pkg/cmd/addon/uninstall.go 0.00% 2 Missing ⚠️
pkg/cmd/addon/addon.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   43.39%   43.54%   +0.14%     
==========================================
  Files         174      174              
  Lines       24500    24710     +210     
==========================================
+ Hits        10632    10760     +128     
- Misses      12637    12707      +70     
- Partials     1231     1243      +12     
Flag Coverage Δ
unittests 43.54% <46.34%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/cmd/addon/install.go Outdated Show resolved Hide resolved
pkg/cmd/addon/search.go Outdated Show resolved Hide resolved
pkg/cmd/addon/install.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 24, 2024
@yipeng1030 yipeng1030 force-pushed the feature/create_cluster_adapt_new_API branch from 4e9ba0c to 2442d5b Compare September 24, 2024 09:16
@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Sep 24, 2024
@yipeng1030 yipeng1030 merged commit ef8ac80 into main Sep 25, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the feature/create_cluster_adapt_new_API branch September 25, 2024 02:26
@github-actions github-actions bot added this to the Release 0.9.1 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Kbcli support KubeBlocks 0.9 & 1.0 API
3 participants