Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Reconciliation Tracing #454

Merged
merged 38 commits into from
Nov 26, 2024
Merged

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Oct 9, 2024

@free6om free6om added this to the Release 1.0 milestone Oct 9, 2024
@free6om free6om self-assigned this Oct 9, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 8.86559% with 956 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (8413ce3) to head (80adc7b).

Files with missing lines Patch % Lines
...e/chart/timeserieslinechart/timeserieslinechart.go 0.00% 336 Missing ⚠️
pkg/cmd/trace/chart/reconciliation_trace_chart.go 0.00% 248 Missing ⚠️
pkg/cmd/trace/chart/objecttree/tree_chart.go 0.00% 85 Missing ⚠️
pkg/cmd/trace/chart/timeserieslinechart/options.go 0.00% 66 Missing ⚠️
pkg/cmd/trace/chart/summary/summary_chart.go 0.00% 54 Missing ⚠️
pkg/cmd/trace/watch.go 14.03% 48 Missing and 1 partial ⚠️
pkg/cmd/trace/chart/richviewport/viewport.go 21.81% 43 Missing ⚠️
pkg/cmd/trace/update.go 34.69% 31 Missing and 1 partial ⚠️
...d/trace/chart/timeserieslinechart/updatehandler.go 0.00% 16 Missing ⚠️
pkg/cmd/trace/delete.go 38.09% 12 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   42.55%   41.11%   -1.45%     
==========================================
  Files         172      185      +13     
  Lines       23300    24349    +1049     
==========================================
+ Hits         9916    10011      +95     
- Misses      12249    13198     +949     
- Partials     1135     1140       +5     
Flag Coverage Δ
unittests 41.11% <8.86%> (-1.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om changed the title feat: Support Reconciliation View feat: Support Reconciliation Trace Oct 15, 2024
@free6om free6om marked this pull request as ready for review October 21, 2024 10:04
@free6om free6om changed the title feat: Support Reconciliation Trace feat: Support Reconciliation Tracing Oct 21, 2024
Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@free6om free6om merged commit 83f3123 into main Nov 26, 2024
12 checks passed
@free6om free6om deleted the support/reconciliation-view branch November 26, 2024 07:56
@free6om
Copy link
Contributor Author

free6om commented Nov 26, 2024

/cherry-pick release-1.0-beta

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/12026182948

@free6om
Copy link
Contributor Author

free6om commented Nov 26, 2024

/cherry-pick release-1.0

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/12026197693

github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants