Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Reconciliation Tracing #454

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Oct 9, 2024

@free6om free6om added this to the Release 1.0 milestone Oct 9, 2024
@free6om free6om self-assigned this Oct 9, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 10.47297% with 795 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (15d1aac) to head (01613dd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e/chart/timeserieslinechart/timeserieslinechart.go 0.00% 281 Missing ⚠️
pkg/cmd/trace/chart/reconciliation_trace_chart.go 0.00% 227 Missing ⚠️
pkg/cmd/trace/chart/timeserieslinechart/options.go 0.00% 66 Missing ⚠️
pkg/cmd/trace/chart/summary/summary_chart.go 0.00% 54 Missing ⚠️
pkg/cmd/trace/watch.go 14.03% 48 Missing and 1 partial ⚠️
pkg/cmd/trace/chart/richviewport/viewport.go 21.81% 43 Missing ⚠️
pkg/cmd/trace/update.go 34.69% 31 Missing and 1 partial ⚠️
...d/trace/chart/timeserieslinechart/updatehandler.go 0.00% 16 Missing ⚠️
pkg/cmd/trace/delete.go 38.09% 12 Missing and 1 partial ⚠️
pkg/cmd/trace/create.go 67.74% 9 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   41.61%   40.45%   -1.16%     
==========================================
  Files         165      177      +12     
  Lines       22904    23792     +888     
==========================================
+ Hits         9531     9626      +95     
- Misses      12257    13045     +788     
- Partials     1116     1121       +5     
Flag Coverage Δ
unittests 40.45% <10.47%> (-1.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om changed the title feat: Support Reconciliation View feat: Support Reconciliation Trace Oct 15, 2024
@free6om free6om marked this pull request as ready for review October 21, 2024 10:04
@free6om free6om changed the title feat: Support Reconciliation Trace feat: Support Reconciliation Tracing Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants