Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cmpd/cmpv list/describe adapt 1.0 api #479

Merged
merged 12 commits into from
Nov 5, 2024

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Oct 28, 2024

  1. cmpd list.
    NAME SERVICE SERVICE-VERSION PROVIDER STATUS CREATED-TIME
  2. cmpd describe
image 3. cmpv list. `NAME VERSIONS STATUS CREATED-TIME` 4. cmpv describe image

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 28, 2024
@yipeng1030 yipeng1030 changed the title feat: cd cmpd cmpv support list and describe feat: cd cmpd cmpv adapt 1.0 api Oct 28, 2024
@yipeng1030 yipeng1030 changed the title feat: cd cmpd cmpv adapt 1.0 api improvement: cd cmpd cmpv adapt 1.0 api Oct 28, 2024
@yipeng1030 yipeng1030 changed the title improvement: cd cmpd cmpv adapt 1.0 api chore: cd cmpd cmpv adapt 1.0 api Oct 28, 2024
@yipeng1030 yipeng1030 changed the title chore: cd cmpd cmpv adapt 1.0 api chore: cmpd/cmpv list/describe deadapt 1.0 api Oct 28, 2024
@yipeng1030 yipeng1030 changed the title chore: cmpd/cmpv list/describe deadapt 1.0 api chore: cmpd/cmpv list/describe adapt 1.0 api Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 19.87952% with 266 lines in your changes missing coverage. Please review.

Project coverage is 41.73%. Comparing base (2e2279f) to head (a8a34e0).

Files with missing lines Patch % Lines
pkg/cmd/componentdefinition/describe.go 7.18% 154 Missing and 1 partial ⚠️
pkg/cmd/componentversion/describe.go 16.90% 58 Missing and 1 partial ⚠️
pkg/cmd/componentdefinition/componnetdefinition.go 31.25% 43 Missing and 1 partial ⚠️
pkg/cmd/componentversion/componentversion.go 80.00% 4 Missing and 1 partial ⚠️
pkg/cmd/clusterdefinition/describe.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   42.02%   41.73%   -0.30%     
==========================================
  Files         167      171       +4     
  Lines       22984    23314     +330     
==========================================
+ Hits         9660     9730      +70     
- Misses      12210    12467     +257     
- Partials     1114     1117       +3     
Flag Coverage Δ
unittests 41.73% <19.87%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei self-requested a review October 30, 2024 07:41
pkg/cmd/componentversion/componentversion.go Outdated Show resolved Hide resolved
pkg/cmd/componentversion/describe.go Outdated Show resolved Hide resolved
@wangyelei wangyelei self-requested a review October 30, 2024 07:43
@yipeng1030 yipeng1030 merged commit 0c7d968 into main Nov 5, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the feature/cd_cmpd_cmpv_support_list_and_describe branch November 5, 2024 10:28
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants