Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade kb failed because no KB deployment was found. #498

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei changed the title fix: pgrade failed because no KB deployment was found. fix: upgrade kb failed because no KB deployment was found. Nov 25, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.55%. Comparing base (e6282c9) to head (7a3e549).

Files with missing lines Patch % Lines
pkg/cmd/kubeblocks/upgrade.go 50.00% 0 Missing and 2 partials ⚠️
pkg/cmd/kubeblocks/install_1.0.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   42.59%   42.55%   -0.04%     
==========================================
  Files         172      172              
  Lines       23328    23300      -28     
==========================================
- Hits         9937     9916      -21     
+ Misses      12255    12249       -6     
+ Partials     1136     1135       -1     
Flag Coverage Δ
unittests 42.55% <57.14%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit 8413ce3 into main Nov 25, 2024
12 checks passed
@wangyelei wangyelei deleted the bugfix/kbcli_upgrade_failed branch November 25, 2024 10:07
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0

@github-actions github-actions bot added this to the Release 1.0 milestone Nov 25, 2024
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/12007711214

github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants