-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: playground init support specifying k3s and k3d-proxy images. #500
Conversation
1918124
to
4621556
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 42.59% 42.58% -0.01%
==========================================
Files 172 172
Lines 23328 23337 +9
==========================================
+ Hits 9937 9939 +2
- Misses 12255 12261 +6
- Partials 1136 1137 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to encode infos (k3sImage string, k3dProxyImage string) into a struct.
/cherry-pick release-1.0 |
🤖 says: cherry pick action finished successfully 🎉! |
fix #488
playground init
support specifying k3s and k3d-proxy images by two flags--k3s-image
and--k3d-proxy-image
.kbcli playground init --k3d-proxy-image=registry.aliyuncs.com/apecloud/k3d-proxy:5.4.4
to specify the image of k3d-proxy.