Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: playground init support specifying k3s and k3d-proxy images. #500

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Nov 27, 2024

fix #488

  • playground init support specifying k3s and k3d-proxy images by two flags --k3s-image and --k3d-proxy-image.
  • For example, you can use kbcli playground init --k3d-proxy-image=registry.aliyuncs.com/apecloud/k3d-proxy:5.4.4 to specify the image of k3d-proxy.
  • fix a bug of remaining test file after running ut in cmd/cluster.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 27, 2024
@yipeng1030 yipeng1030 force-pushed the feature/k3d_support_specify_registry branch from 1918124 to 4621556 Compare November 27, 2024 07:24
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 42.58%. Comparing base (e6282c9) to head (32a9866).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/playground/init.go 33.33% 4 Missing ⚠️
pkg/cmd/cluster/operations.go 0.00% 2 Missing and 1 partial ⚠️
pkg/cloudprovider/k3d.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   42.59%   42.58%   -0.01%     
==========================================
  Files         172      172              
  Lines       23328    23337       +9     
==========================================
+ Hits         9937     9939       +2     
- Misses      12255    12261       +6     
- Partials     1136     1137       +1     
Flag Coverage Δ
unittests 42.58% <52.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Nov 27, 2024
Copy link
Contributor

@shanshanying shanshanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to encode infos (k3sImage string, k3dProxyImage string) into a struct.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] specify K3d registry in playground
3 participants