Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve cluster list #516

Merged
merged 3 commits into from
Dec 13, 2024
Merged

feat: improve cluster list #516

merged 3 commits into from
Dec 13, 2024

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Dec 11, 2024

fix #448

what's changed?

  1. improve order of cluster list, now the sort order is namespace、clusterDefinition、 status、 name.
  2. add a flag of cluster list to specify the status to filter.

usage:
kbcli cluster list --status=Running

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 11, 2024
@yipeng1030 yipeng1030 changed the title Feature/improve cluster list feat: improve cluster list Dec 11, 2024
@yipeng1030 yipeng1030 force-pushed the feature/improve_cluster_list branch from f1836ba to c8544ef Compare December 11, 2024 12:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.46154% with 64 lines in your changes missing coverage. Please review.

Project coverage is 41.18%. Comparing base (96adf78) to head (6901729).

Files with missing lines Patch % Lines
pkg/cluster/printer.go 36.00% 63 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   41.22%   41.18%   -0.04%     
==========================================
  Files         185      185              
  Lines       24398    24482      +84     
==========================================
+ Hits        10058    10083      +25     
- Misses      13189    13247      +58     
- Partials     1151     1152       +1     
Flag Coverage Δ
unittests 41.18% <38.46%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 marked this pull request as ready for review December 11, 2024 12:23
@yipeng1030 yipeng1030 merged commit 788adb4 into main Dec 13, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the feature/improve_cluster_list branch December 13, 2024 07:21
@github-actions github-actions bot added this to the Release 1.0 milestone Dec 13, 2024
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/12311351300

apecloud-bot pushed a commit that referenced this pull request Dec 13, 2024
(cherry picked from commit 788adb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] adjust kbcli cluster list order
4 participants