Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Features] Implement ComponentDefinition's PolicyRules #8310

Open
cjc7373 opened this issue Oct 22, 2024 · 2 comments · May be fixed by #8328
Open

[Features] Implement ComponentDefinition's PolicyRules #8310

cjc7373 opened this issue Oct 22, 2024 · 2 comments · May be fixed by #8328
Assignees
@cjc7373
Labels
area/user-interaction kind/feature New feature Stale
Milestone
Release 1.0.0

Comments

@cjc7373
Copy link
Contributor

cjc7373 commented Oct 22, 2024

Some engine may need to interact with k8s, thus needs rbac. ComponentDefinition has a PolicyRules field but is unimplemented. Currently pods will get a role defined in https://github.com/apecloud/kubeblocks/blob/cdd2d013b424dba4645b131bb441630f2e1e1222/deploy/helm/templates/rbac/cluster_pod_required_role.yaml.

We need to remove this file and implement PolicyRules in cmpd.
@cjc7373 cjc7373 self-assigned this Oct 22, 2024
@cjc7373 cjc7373 added this to the Release 1.0.0 milestone Oct 22, 2024
@cjc7373
Copy link
Contributor Author

cjc7373 commented Oct 22, 2024 •
edited
Loading

Some notes:

  • If user has specified a ServiceAccountName in component's spec, then kb will not generate serviceaccount/role/rolebinding.
  • kb-agent does not need most of kubeblocks-lorry-pod-role, but still needs one rule to create event.

@cjc7373 cjc7373 linked a pull request Oct 24, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 30 days with no activity

@github-actions github-actions bot added the Stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjc7373 cjc7373

Labels
area/user-interaction kind/feature New feature Stale
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

feat: implement cmpd's PolicyRules apecloud/kubeblocks
1 participant
@cjc7373