feat: implement cmpd's PolicyRules #8328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjc7373
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8328 +/- ##
==========================================
+ Coverage 61.29% 62.06% +0.76%
==========================================
Files 350 351 +1
Lines 41172 41751 +579
==========================================
+ Hits 25236 25911 +675
+ Misses 13637 13533 -104
- Partials 2299 2307 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
reviewed
Oct 30, 2024
cjc7373
commented
Oct 31, 2024
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: kubeblocks-backup-pod-role |
There was a problem hiding this comment.
This role is also not needed since relavant code removed in #8203
zjx20
approved these changes
Oct 31, 2024
Y-Rookie
reviewed
Nov 1, 2024
| @@ -166,33 +164,9 @@ func kindsForWipeOut() ([]client.ObjectList, []client.ObjectList) { | |||
|
|
|||
| // shouldSkipObjOwnedByComp is used to judge whether the object owned by component should be skipped when deleting the cluster | |||
| func shouldSkipObjOwnedByComp(obj client.Object, cluster kbappsv1.Cluster) bool { | |||
There was a problem hiding this comment.
remove shouldSkipObjOwnedByComp and use isOwnedByComp directly
Y-Rookie
reviewed
Nov 1, 2024
| // If the user has disabled rbac manager or specified comp.Spec.ServiceAccountName, it is now the user's responsibility to | ||
| // provide appropriate serviceaccount, roles and rolebindings. | ||
| if transCtx.Component.Spec.ServiceAccountName != "" { | ||
| return nil |
There was a problem hiding this comment.
if SA is not exist, raise an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8310. Things done in this PR:
serviceAccountNamein cluster and component CR. KB now does not create rbac resources if user has specified a service account.kb-<clusterName>-<compName>.TODO: