Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve Lorry performance #6109

Merged
merged 6 commits into from
Dec 18, 2023
Merged

chore: improve Lorry performance #6109

merged 6 commits into from
Dec 18, 2023

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 14, 2023
@xuriwuyun xuriwuyun linked an issue Dec 14, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f1fa247) 68.42% compared to head (28dd17f) 68.23%.
Report is 11 commits behind head on main.

Files Patch % Lines
pkg/dataprotection/utils/utils.go 0.00% 12 Missing ⚠️
pkg/dataprotection/restore/manager.go 63.63% 3 Missing and 1 partial ⚠️
pkg/controller/component/vars.go 62.50% 3 Missing ⚠️
...roller/component/component_definition_convertor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6109      +/-   ##
==========================================
- Coverage   68.42%   68.23%   -0.20%     
==========================================
  Files         295      295              
  Lines       33716    33740      +24     
==========================================
- Hits        23070    23021      -49     
- Misses       8727     8800      +73     
  Partials     1919     1919              
Flag Coverage Δ
unittests 68.23% <53.48%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuriwuyun
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 18, 2023
@xuriwuyun xuriwuyun merged commit 9680158 into main Dec 18, 2023
73 of 75 checks passed
@xuriwuyun xuriwuyun deleted the feature/mysql_ha_improve branch December 18, 2023 09:53
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 18, 2023
@xuriwuyun
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/7246386272

github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Primary-Secondary mysql will occasionally lost data when failover
4 participants