Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto creating component obj when upgrade to KubeBlocks v0.8.0 #6221

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

Y-Rookie
Copy link
Collaborator

@Y-Rookie Y-Rookie commented Dec 25, 2023

fix: #6131

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Dec 25, 2023
@Y-Rookie Y-Rookie linked an issue Dec 25, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (4ed7a92) 67.96% compared to head (aa9054a) 67.80%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/controllerutil/controller_common.go 0.00% 34 Missing ⚠️
pkg/dataprotection/restore/utils.go 0.00% 34 Missing ⚠️
pkg/dataprotection/restore/builder.go 24.24% 25 Missing ⚠️
...trollers/apps/transformer_cluster_backup_policy.go 60.52% 12 Missing and 3 partials ⚠️
pkg/controller/plan/restore.go 54.83% 9 Missing and 5 partials ⚠️
controllers/apps/operations/restore.go 0.00% 6 Missing ⚠️
controllers/apps/transformer_cluster_component.go 66.66% 4 Missing and 2 partials ⚠️
controllers/dataprotection/backup_controller.go 0.00% 4 Missing and 1 partial ⚠️
pkg/dataprotection/backup/request.go 50.00% 4 Missing and 1 partial ⚠️
controllers/apps/operations/backup.go 0.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6221      +/-   ##
==========================================
- Coverage   67.96%   67.80%   -0.16%     
==========================================
  Files         297      297              
  Lines       34536    34673     +137     
==========================================
+ Hits        23472    23511      +39     
- Misses       9093     9190      +97     
- Partials     1971     1972       +1     
Flag Coverage Δ
unittests 67.80% <35.04%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie
Copy link
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 25, 2023
@Y-Rookie Y-Rookie merged commit b733b1f into main Dec 25, 2023
73 of 75 checks passed
@Y-Rookie Y-Rookie deleted the bugfix/redis-070-upgrade-080-failed branch December 25, 2023 07:44
@Y-Rookie
Copy link
Collaborator Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 25, 2023
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/7320156922

github-actions bot pushed a commit that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]redis pod crash after upgrade kb from 0.7.2 to 0.8
3 participants