Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align pitr backup retention with cluster retentionPeriod #8297

Conversation

fengluodb
Copy link
Contributor

align pitr backup retention with cluster retentionPeriod in backup schedule

@fengluodb fengluodb requested review from leon-inf, Y-Rookie and a team as code owners October 18, 2024 02:23
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 18, 2024
@fengluodb fengluodb requested a review from ldming October 18, 2024 02:29
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.51%. Comparing base (dcf84ed) to head (c897cb9).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/apps/transformer_cluster_backup_policy.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8297      +/-   ##
==========================================
+ Coverage   61.35%   61.51%   +0.15%     
==========================================
  Files         350      350              
  Lines       41162    41248      +86     
==========================================
+ Hits        25257    25373     +116     
+ Misses      13611    13580      -31     
- Partials     2294     2295       +1     
Flag Coverage Δ
unittests 61.51% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 18, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Oct 18, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 21, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 24, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 24, 2024
@fengluodb fengluodb merged commit d5e908b into main Nov 6, 2024
37 checks passed
@fengluodb fengluodb deleted the bugfix/aligin-pitr-backup-retention-with-cluster-retentionPeriod branch November 6, 2024 03:01
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 6, 2024
@fengluodb
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

github-actions bot commented Nov 6, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/11696441686

@shanshanying
Copy link
Contributor

/cherry-pick release-1.0-beta

Copy link

github-actions bot commented Nov 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/11715013320

github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Update cluster retentionPeriod without change PITR backup retention"
7 participants