Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve calculate mysql buffer pool size #8325

Merged
merged 4 commits into from
Oct 24, 2024
Merged

chore: improve calculate mysql buffer pool size #8325

merged 4 commits into from
Oct 24, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner October 24, 2024 07:27
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 24, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 24, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Oct 24, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.52%. Comparing base (3e2f8d9) to head (a5b1df6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/configuration/builtin_functions.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8325      +/-   ##
==========================================
+ Coverage   61.13%   61.52%   +0.38%     
==========================================
  Files         350      350              
  Lines       41172    41172              
==========================================
+ Hits        25172    25332     +160     
+ Misses      13708    13572     -136     
+ Partials     2292     2268      -24
Flag Coverage Δ
unittests 61.52% <75.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added approved PR Approved Test and removed approved PR Approved Test labels Oct 24, 2024
@wangyelei wangyelei force-pushed the bugfix/improve_mysql_bool_size branch from e2095dd to a5b1df6 Compare October 24, 2024 08:27
@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 24, 2024
@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit e3508fb into main Oct 24, 2024
59 checks passed
@wangyelei wangyelei deleted the bugfix/improve_mysql_bool_size branch October 24, 2024 10:11
@github-actions github-actions bot added this to the Release 0.9.2 milestone Oct 24, 2024
@kizuna-lek
Copy link
Collaborator

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/11550456441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@zjx20 zjx20 zjx20 approved these changes

@shanshanying shanshanying shanshanying approved these changes

@sophon-zt sophon-zt sophon-zt approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

Assignees
No one assigned
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
7 participants
@wangyelei @kizuna-lek @ldming @zjx20 @shanshanying @sophon-zt @apecloud-bot