fix: build config-manager container NPE #8335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8335 +/- ##
==========================================
+ Coverage 61.30% 62.21% +0.91%
==========================================
Files 350 351 +1
Lines 41225 42489 +1264
==========================================
+ Hits 25271 26434 +1163
- Misses 13667 13753 +86
- Partials 2287 2302 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
approved these changes
Oct 25, 2024
| ToolConfigs: []appsv1beta1.ToolConfig{ | ||
| { | ||
| Name: "tools_name", | ||
| AsContainerImage: func() *bool { var b = true; return &b }(), |
There was a problem hiding this comment.
wangyelei
approved these changes
Nov 5, 2024
sophon-zt
deleted the
bugfix/build-config-manager-container-npe-issue8333
branch
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
(cherry picked from commit 67a0f6f)
sophon-zt
added a commit
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit 67a0f6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.