feat: switchover supports Sharding API #8352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancelot1989
commented
Oct 29, 2024
•
lancelot1989
commented
- fix [Improvement]Switchover improve to support Sharding API #8351
lancelot1989
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
Y-Rookie
as code owners
|
|
wangyelei
reviewed
Oct 30, 2024
| shardingSpec := opsRes.Cluster.Spec.GetShardingByName(switchover.ComponentName) | ||
| var synthesizedComp *component.SynthesizedComponent | ||
| var err error | ||
| if nil != compSpec { |
| return validateBaseOnClusterCompDef(cluster.Spec.GetComponentDefRefName(switchover.ComponentName)) | ||
| } | ||
| } | ||
| if shardingSpec != nil { |
There was a problem hiding this comment.
use else if , component name is unique in cluster
| return nil, err | ||
| } | ||
| } | ||
| if nil != shardingSpec { |
| } | ||
| return comps, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
you can reuse the intctrlutil.ListShardingComponents function
|
Hi @lancelot1989 , Thanks for your PR. |
wangyelei
reviewed
Oct 30, 2024
| component = cmp | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
check whether component is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.