Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to install coversion webhook when install kb 1.0 #8399

Merged
merged 15 commits into from
Nov 8, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from ldming and a team as code owners November 5, 2024 06:39
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (1fd8585) to head (9e4e10c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8399      +/-   ##
==========================================
+ Coverage   61.05%   61.42%   +0.37%     
==========================================
  Files         351      351              
  Lines       41727    41727              
==========================================
+ Hits        25476    25632     +156     
+ Misses      13951    13801     -150     
+ Partials     2300     2294       -6     
Flag Coverage Δ
unittests 61.42% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei force-pushed the feature/upgrade_1.0 branch 2 times, most recently from 7388794 to ce2aaab Compare November 6, 2024 02:51
Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 7, 2024
deploy/helm/values.yaml Show resolved Hide resolved
deploy/helm/Chart.yaml Outdated Show resolved Hide resolved
deploy/helm/templates/rbac/cluster_pod_required_role.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where will this script be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before using Helm to install version 1.0, users need to manually execute the following steps:

@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 8, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 8, 2024
@wangyelei wangyelei merged commit 928f3f2 into main Nov 8, 2024
35 checks passed
@wangyelei wangyelei deleted the feature/upgrade_1.0 branch November 8, 2024 02:22
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 8, 2024
wangyelei added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants