Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ops is always running #8417

Merged
merged 2 commits into from
Nov 7, 2024
Merged

chore: upgrade ops is always running #8417

merged 2 commits into from
Nov 7, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner November 6, 2024 10:26
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 6, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 6, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 7, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 7, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 7, 2024
@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.47%. Comparing base (9613375) to head (d471989).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/upgrade.go 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8417      +/-   ##
==========================================
+ Coverage   61.28%   61.47%   +0.18%     
==========================================
  Files         351      351              
  Lines       41739    41727      -12     
==========================================
+ Hits        25579    25650      +71     
+ Misses      13856    13784      -72     
+ Partials     2304     2293      -11     
Flag Coverage Δ
unittests 61.47% <66.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 1fd8585 into main Nov 7, 2024
35 checks passed
@wangyelei wangyelei deleted the bugfix/upgrade_bug branch November 7, 2024 02:04
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 7, 2024
wangyelei added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants