Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost event during image rolling update #8424

Merged

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Nov 7, 2024

No description provided.

@free6om free6om added this to the Release 0.9.2 milestone Nov 7, 2024
@free6om free6om self-assigned this Nov 7, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (d8b3f9f) to head (716b7d2).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8424      +/-   ##
===============================================
+ Coverage        64.92%   64.94%   +0.02%     
===============================================
  Files              358      358              
  Lines            45425    45431       +6     
===============================================
+ Hits             29491    29504      +13     
- Misses           13306    13309       +3     
+ Partials          2628     2618      -10     
Flag Coverage Δ
unittests 64.94% <16.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 7, 2024
@free6om
Copy link
Contributor Author

free6om commented Nov 7, 2024

/approve

@free6om free6om merged commit 0da21a0 into release-0.9 Nov 7, 2024
41 of 43 checks passed
@free6om free6om deleted the bugfix/fix-lost-event-during-image-rolling-update branch November 7, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants