Skip to content

chore: support to convert shardings api in conversion webhook #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

chore: support to convert shardings api in conversion webhook #8766

merged 2 commits into from
Jan 9, 2025

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners January 8, 2025 08:57
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 8, 2025
@wangyelei wangyelei changed the title chore: support to convert shardings and shardingSpecs chore: support to convert shardings api in conversion webhook Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (fd21c31) to head (0266ec6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apis/apps/v1alpha1/cluster_conversion.go 0.00% 38 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8766      +/-   ##
==========================================
- Coverage   60.50%   60.45%   -0.06%     
==========================================
  Files         378      378              
  Lines       45955    45973      +18     
==========================================
- Hits        27807    27792      -15     
- Misses      15505    15541      +36     
+ Partials     2643     2640       -3
Flag Coverage Δ
unittests 60.45% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 9, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jan 9, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 9, 2025
@wangyelei wangyelei merged commit 0d7336f into main Jan 9, 2025
33 of 35 checks passed
@wangyelei wangyelei deleted the bugfix/sharding_1.0_bug branch January 9, 2025 11:37
@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 9, 2025
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12689142217

apecloud-bot pushed a commit that referenced this pull request Jan 9, 2025
@wangyelei
chore: support to convert shardings api in conversion webhook (#8766)
eb6a8b0 
(cherry picked from commit 0d7336f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@zjx20 zjx20 zjx20 approved these changes

@leon-inf leon-inf leon-inf approved these changes

+1 more reviewer

@Y-Rookie Y-Rookie Y-Rookie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
6 participants
@wangyelei @apecloud-bot @ldming @zjx20 @Y-Rookie @leon-inf