Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: h-scale opsRequest validation considers replicas and shards limit #8834

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: h-scale opsRequest validation considers replicas and shards limit #8834

wants to merge 9 commits into from

Conversation

yipeng1030
Copy link
Contributor

fix #8737

add a validation rule that a opsRequest can't offlines all the online replicas of a component.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 20, 2025
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Jan 20, 2025
@yipeng1030 yipeng1030 changed the title bugfix: reject the opsRequest that offlines all the replicas of a component fix: reject the opsRequest that offlines all the replicas of a component Jan 20, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Jan 20, 2025
@yipeng1030 yipeng1030 marked this pull request as ready for review January 20, 2025 14:18
@yipeng1030 yipeng1030 requested review from wangyelei and a team as code owners January 20, 2025 14:18
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 6, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 6, 2025
@yipeng1030 yipeng1030 marked this pull request as draft February 6, 2025 09:28
@apecloud-bot apecloud-bot removed the pre-approve Fork PR Pre Approve Test label Feb 6, 2025
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Feb 6, 2025
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Feb 6, 2025
@yipeng1030 yipeng1030 marked this pull request as ready for review February 6, 2025 09:44
@yipeng1030 yipeng1030 changed the title fix: reject the opsRequest that offlines all the replicas of a component fix: h-scale opsRequest validation considers replica limit Feb 6, 2025
@yipeng1030 yipeng1030 changed the title fix: h-scale opsRequest validation considers replica limit fix: h-scale opsRequest validation considers replicas and shards limit Feb 6, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leon-inf leon-inf leon-inf left review comments

@wangyelei wangyelei wangyelei approved these changes

@JashBook JashBook Awaiting requested review from JashBook

@ahjing99 ahjing99 Awaiting requested review from ahjing99

@linghan-hub linghan-hub Awaiting requested review from linghan-hub

@michelle-0808 michelle-0808 Awaiting requested review from michelle-0808

@shanshanying shanshanying Awaiting requested review from shanshanying

@ldming ldming Awaiting requested review from ldming

@zjx20 zjx20 Awaiting requested review from zjx20

@sophon-zt sophon-zt Awaiting requested review from sophon-zt

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
pre-approve Fork PR Pre Approve Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]HscaleOfflineInstances is always in running status when scaleIn component that only has 1 replicas
4 participants
@yipeng1030 @wangyelei @leon-inf @apecloud-bot