Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications don't have icons #47

Closed
allanday opened this issue Mar 15, 2017 · 2 comments
Closed

Notifications don't have icons #47

allanday opened this issue Mar 15, 2017 · 2 comments
Assignees

Comments

@allanday
Copy link

Each notification should have an icon with it. In GNOME 3.22 a full colour application icon is used, although in 3.24 we are switching to use symbolics.

In both cases, notifications from Revolt don't have an icon, which doesn't look so great.

@aperezdc aperezdc self-assigned this Mar 16, 2017
@aperezdc
Copy link
Owner

Initially I didn't add the application icon because I was hoping of finding some way of getting the avatar of the room/user who caused the notification, but never got round to it. There's already a symbolic icon for Revolt, it should be a piece of cake to pass it to the GNotification.

aperezdc added a commit that referenced this issue Mar 16, 2017
@aperezdc
Copy link
Owner

It turns out that notif.set_icon() was being called, but the name of the icon being loaded was one that doesn't exist anymore. I fixed that and also changed over to use the symbolic icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants