Dictionary lookup handler #61
Conversation
| self.pipeline_cmds[(l1, l2)] = translation.parseModeFile(mode_path) | ||
| return self.pipeline_cmds[(l1, l2)] | ||
|
|
||
| def getPairOrError(self, langpair): |
There was a problem hiding this comment.
Looks like this function is repeated? Maybe we should extract it BaseHandler?
There was a problem hiding this comment.
Um, not all classes that extend BaseHandler use it. Do you suggest putting it at the BaseHandler level so that all the classes which extend it have this method?
There was a problem hiding this comment.
Do you suggest putting it at the BaseHandler level so that all the classes which extend it have this method?
Yes.
| @@ -343,6 +343,14 @@ def translateSimple(toTranslate, commands): | |||
| proc_in.stdout.close() | |||
| return translated.decode('utf-8') | |||
|
|
|||
| @gen.coroutine | |||
| def translateNoFlush(toTranslate, commands): | |||
There was a problem hiding this comment.
This looks like the same as translateSimple?
There was a problem hiding this comment.
Yes indeed. I've removed it.
There was a problem hiding this comment.
@sushain97 , the assert proc_in == proc_out line in translateSimple which is not present in translateNoFlush gives an assertion error.
|
How do I resolve the current Travis build error? It fails with this message: |
|
Hm, I tried re-running the build to see if it was a transient error but that didn't help. @unhammer, thoughts? |
|
https://travis-ci.org/goavki/apertium-apy/jobs/264033108 says it's flake8 issues, which travis build? |
|
Ah, indeed! It looks like the transient DTD error has not subsisted after the re-build. @share-with-me check out the build output again. Thanks, @unhammer. |
sushain97
force-pushed
the
master
branch
2 times, most recently
from
b36ac97
to
51fb9c5
Compare
No description provided.