Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple spellings #86

Open
ftyers opened this issue Nov 12, 2020 · 12 comments
Open

Add multiple spellings #86

ftyers opened this issue Nov 12, 2020 · 12 comments
Labels
enhancement New feature or request

Comments

@ftyers
Copy link
Member

ftyers commented Nov 12, 2020

I keep doing analyse() instead of analyze() :(

@ftyers ftyers added the enhancement New feature or request label Nov 12, 2020
@juuz0
Copy link

juuz0 commented Nov 26, 2020

Can I take this?
Would I need to provide an alternative for the class name too (Analyzer) or just providing an alternative name for analyze (analyse) is enough?

@b-thebest
Copy link

Can I fix it ?

@ftyers
Copy link
Member Author

ftyers commented Dec 4, 2020

@juuz0 I guess that would be better yep.

@b-thebest I don't know, you can try!

@b-thebest
Copy link

@ftyers I don't find occurance of analyse(), I think its already been done

@mr-martian
Copy link

@b-thebest that's the issue, the code currently has the american spelling (with a z) and it would be nice if it also had the spelling with an s.

@b-thebest
Copy link

@mr-martian So, we need to change occurance of "analyze" ==> "analyse"
Is that so?

@mr-martian
Copy link

not simply replace
we want both

@mr-martian
Copy link

that is, we want an alias for the function

@juuz0
Copy link

juuz0 commented Dec 4, 2020

just providing an alias for the analyze() function name would be easy tho, I did that a few days ago :/
but couldn't find a way to provide an alias to the Analyzer class :/

@juuz0
Copy link

juuz0 commented Dec 4, 2020

Hello, I just added a pull request to add the aliases for both Analyzer(Analyser) and analyze(analyse), could you please check? :)

@max-keviv
Copy link

@ftyers if the issue is not resolved can I work on this issue

@TinoDidriksen
Copy link
Member

@max-keviv there is a PR #87 that I approved, but left a question on that never got answered. So only if you can find other interfaces in need of alternative spellings.

richab246 added a commit to richab246/apertium-python that referenced this issue Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants