-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weights are ignored in monolingual dictionary entries #44
Comments
@unhammer I will definitely look into it. |
I might be facing the same problem.
I generate the transducer using
which seems to be correct. However, the output of the |
I think the bug might be related to this line and its following lines: Line 607 in f73c541
|
When computing the overall weight of an analysis, The weight of the final state was ignored. Fix apertium#44
@marcriera I think the bug is with the lt-comp command. I have prepared a sample dictionary:
And the output transducer isn't correct
When I use the command
|
the correct weighting here is not trivial (so there seems to be something wrong in the compilation part too), keep in mind that the prefix "hous" is shared by both verb and noun, and the verb that needs that weight of 2 needs it also for "housing" which does not go through the Here's the hfst + lexc equivalent for reference:
nonetheless for the lt-proc part there should be at least a bit more of the weight accumulated :-/ |
Is lt-comp used in the apertium-eng to compile the dictionary?
it is
|
I believe the issue here is that |
* don't lose weights when minimizing * don't lose weights while compiling * don't duplicate weights while compiling * ensure that final weight after joinFinals() is always 0 * version bump so lexd can depend on this
@mr-martian, it seems at some point you attempted to fix it, but then had to revert. Any idea on what needs to be done? |
The issue is that FST minimization was written for unweighted automata and when weight support for added, |
Given the following paradigms and entries:
lt-proc seems to ignore the weights for the entries:
The expected result would be:
However, the weights work fine when they are used inside a paradigm:
The text was updated successfully, but these errors were encountered: