Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape special symbols in lt-expand? #82

Closed
unhammer opened this issue May 11, 2020 · 4 comments
Closed

escape special symbols in lt-expand? #82

unhammer opened this issue May 11, 2020 · 4 comments

Comments

@unhammer
Copy link
Member

unhammer commented May 11, 2020

Perhaps lt-expand should escape e.g. : as part of form/lemma (DJ:en:DJ<n><m><sg><def> looks like it has three fields). Similarly other reserved chars

@ftyers
Copy link
Member

ftyers commented Jun 20, 2020

I wonder if we shouldn't also be able to compile lt-expanded dictionaries. It could be just another optional format for lt-comp.

@marcriera
Copy link
Member

Reserved characters are still not escaped if they are part of a regular expression. Take the following example, which includes : and becomes difficult to process unless overly complicated regex is used. Otherwise, it looks like it has 4 fields:

__REGEXP__[.\?;:!]+:__REGEXP__[.\?;:!]+<sent>

@mr-martian
Copy link
Contributor

It will now escape ^$/<>{}*@#+~: in regexes. Let me know if that list should be any different.

@marcriera
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants