Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lt-proc --surface-biltrans-keep # assume surface in input, keep surface in output #180

Merged
merged 4 commits into from
Mar 21, 2024
Merged

lt-proc --surface-biltrans-keep # assume surface in input, keep surface in output #180

merged 4 commits into from
Mar 21, 2024

Conversation

unhammer
Copy link
Member

@unhammer unhammer commented Mar 21, 2024 •
edited
Loading

--surf-bilingual:

$ echo '^Unk/unk<foo>$ ^Sted/sted<n><nt>$' | lt-proc -o nob-nno.autobil.bin 
^Unk/@Unk$ ^sted<n><nt>/stad<n><m>$

--surf-bilingual-keep:

$ echo '^Unk/unk<foo>$ ^Sted/sted<n><nt>$' | lt-proc -O nob-nno.autobil.bin
^Unk/Unk/@Unk$ ^Sted/sted<n><nt>/stad<n><m>$

@unhammer unhammer changed the title lt-proc --surface-biltrans-keep # assume surface in input, keep surfa… lt-proc --surface-biltrans-keep # assume surface in input, keep surface in output Mar 21, 2024
mr-martian
mr-martian approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@mr-martian mr-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably also a version bump and maybe a test, but code LGTM

@unhammer
Copy link
Member Author

minor or patch?

unhammer and others added 4 commits March 21, 2024 15:22
@unhammer
tests: callProc needs to return since callers dep on return value
7ff90bd 
+ fix VariantHoTest (" would be read as part of the variant name!)
@mr-martian @unhammer
correct lt-paradigm tests; check for undefined symbols in input
46234b9
@unhammer
lt-proc --surface-biltrans-keep # assume surface in input, keep surfa…
4296490 
…ce in output

--surf-bilingual:

$ echo '^Unk/unk<foo>$ ^Sted/sted<n><nt>$' | lt-proc -o nob-nno.autobil.bin
^Unk/@unk$ ^sted<n><nt>/stad<n><m>$

--surf-bilingual-keep:

$ echo '^Unk/unk<foo>$ ^Sted/sted<n><nt>$' | lt-proc -O nob-nno.autobil.bin
^Unk/Unk/@unk$ ^Sted/sted<n><nt>/stad<n><m>$
@unhammer
lt-proc -o/-O more robust if input missing surface forms
e151ecb 
pretransfer does this with compounds, putting the surface on just one
of the split readings. We at least don't want to output invalid stream
format (before this patch, we'd get
^bad<data>$Ab/ab<n><def>/xy<n><def>$, missing a ^)
@unhammer
Copy link
Member Author

I'll merge for now, I don't know if anything else should go in before a version bump?

@unhammer unhammer merged commit e151ecb into main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-martian mr-martian mr-martian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unhammer @mr-martian