hello a q about reactivity

[SerjoA]

cant get to make the reactive prop to update the chart although it shows that the data has been changed the chart wont update or redraw
can anyone please post example , btw iam on vue 2.1

[apertureless]

Hey,

here is an example: https://github.com/apertureless/vue-chartjs/blob/master/src/examples/ReactiveExample.js

which is also used on the demo page.

If you have issues, please provide a jsfiddle or a minimal repo for reproduction.

However the mixins are very generic. It may be better if you implement an update cyrcle yourself.

Heres the source of the mixin: https://github.com/apertureless/vue-chartjs/blob/master/src/mixins/reactiveProp.js

You can copy paste it as a local mixin and try to add debug output. See if the watcher triggers and if

if (JSON.stringify(newDataLabels) === JSON.stringify(oldDataLabels)) works.

[SerjoA]

checked examples but still wont work, heres a jsfiddle
https://jsfiddle.net/Solutionseje/7bgqzw4s/

[SerjoA]

i solved it with emitting events and updating chart manually
but is there another way?

[SerjoA]

now i have another problem when moving through routes, without keep-alive

Uncaught (in promise) TypeError: Cannot read property 'getContext' of undefined
at VueComponent.renderChart (eval at (app.js:1128), :41642:59)
at VueComponent.boundFn [as renderChart] (eval at (app.js:1128), :338:15)
at VueComponent.updtChrt (eval at (app.js:2274), :23:12)
at Vue$3.boundFn (eval at (app.js:1128), :340:13)
at Vue$3.Vue.$emit (eval at (app.js:604), :2393:16

[apertureless]

Hey @SerjoA

Reactivity

well events are one way to go. Chartjs has no automatic detection if data changes. So you actually always have to manually update the chart / rerender.

Generally there are two ways: one is over events, the other is over the watcher (the mixins are using it) However it can be, that you have to add deep: true to the watcher, because if the data is rather complex it would not see a change.

Thanks for the jsfiddle.

Eh, there are two mixins reactiveProp and reactiveData.

You should use reactiveData only if you store your chartdata into a variable in the data function. Thats for, if you get your data over an api.

If you pass your chartdata as a prop like in your jsfiddle, you should use the reactiveProp mixin.

vue-router

Never used it with vue-router. Do you have a minimal repo to reproduce the error? Hard to debug it without seeing the code.

[SerjoA]

Thnx alot for the info, I'll try to post my code with vue router, ATM I am sick but will do that when I've got a chance, solved all problems BTW with events, added update chart upon event because the mixins somehow didn't work, plus my update chart function basically does, context= chart-id, new chart (context, data) and it worked

[SerjoA]

Thnx for the repo, you are awesome

[apertureless]

Did you tried both mixins? Also the reactiveProp one?

What are you doing, is creating a new chart instance if new data arrives.
Which is not a good idea, because it may not destroy the old instances properly.

You actually need only to call this._chart.update()

[SerjoA]

thank you for the info, will try it and update you, still sick :(
btw i tried both mixins

[SerjoA]

hi, i tried this._chart.update() works good

[SerjoA]

thank you

[apertureless]

Ok, cool.
So can this issue be closed?

[SerjoA]

Yes thank you

…

On Jan 12, 2017 1:23 PM, "Jakub" ***@***.***> wrote: Ok, cool. So can this issue be closed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEIxUFZTI62hVCpudTxv1tl82XqNbHfTks5rRg1KgaJpZM4LdrpG> .