-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Feature/reactive chart data #11 #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.00% (diff: 100%)@@ develop #11 diff @@
==========================================
Files 17 9 -8
Lines 90 70 -20
Methods 1 0 -1
Messages 0 0
Branches 0 0
==========================================
- Hits 82 63 -19
Misses 7 7
+ Partials 1 0 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Glad you found the time to do it! 👍 😃
Would love to have this feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reactive Chart Updates on data changes
Still a 🚧 WIP PR, tests need to be updated.
Implements two mixins discussed in Issue #10
reactiveData
reactiveProp
If you want the chart to re-render or update if new data arrives, you can add one of those mixins.
The Problem is, that this can't be done per default. Because this would cut off a lot of flexibility.
On a SPA you might have a data() variable with your chartData. If you use it in PHP or some other environment you might pass it as a prop. Thats why there are two mixins.
They will automatically create data or prop called
chartData
and add a watcher. And re-renders / update on data change.