Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Feature/reactive chart data #11 #11

Merged
merged 11 commits into from
Oct 15, 2016

Conversation

apertureless
Copy link
Owner

Reactive Chart Updates on data changes

Still a 🚧 WIP PR, tests need to be updated.

Implements two mixins discussed in Issue #10

  • reactiveData
  • reactiveProp

If you want the chart to re-render or update if new data arrives, you can add one of those mixins.
The Problem is, that this can't be done per default. Because this would cut off a lot of flexibility.

On a SPA you might have a data() variable with your chartData. If you use it in PHP or some other environment you might pass it as a prop. Thats why there are two mixins.

They will automatically create data or prop called chartData and add a watcher. And re-renders / update on data change.

@codecov-io
Copy link

codecov-io commented Oct 2, 2016

Current coverage is 90.00% (diff: 100%)

Merging #11 into develop will decrease coverage by 1.11%

@@            develop        #11   diff @@
==========================================
  Files            17          9     -8   
  Lines            90         70    -20   
  Methods           1          0     -1   
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits             82         63    -19   
  Misses            7          7          
+ Partials          1          0     -1   

Sunburst

Diff Coverage File Path
•••••••••• 100% src/index.js

Powered by Codecov. Last update ae93b96...6f77de8

@apertureless apertureless changed the base branch from master to develop October 2, 2016 16:38
Copy link

@blomdahldaniel blomdahldaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Glad you found the time to do it! 👍 😃

@agauniyal
Copy link

Would love to have this feature 👍

@apertureless apertureless merged commit 2df29e1 into develop Oct 15, 2016
@apertureless apertureless deleted the feature/reactive_chart_data branch October 24, 2016 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants