Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Remove generateLegend() from initialization codes #145

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

k-rumi
Copy link
Contributor

@k-rumi k-rumi commented Jul 8, 2017

Fix
Remove nonsense code
chartjs/Chart.js#2177

Fix or Enhancement?

  • All tests passed

Environment

  • OS: Ubuntu 16.04LTS
  • NPM Version: 5.0.4

@codecov
Copy link

codecov bot commented Jul 8, 2017

Codecov Report

Merging #145 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop   #145   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           11     11           
  Lines          114    105    -9     
======================================
- Hits           114    105    -9
Impacted Files Coverage Δ
src/BaseCharts/Bubble.js 100% <ø> (ø) ⬆️
src/BaseCharts/Pie.js 100% <ø> (ø) ⬆️
src/BaseCharts/Doughnut.js 100% <ø> (ø) ⬆️
src/BaseCharts/Scatter.js 100% <ø> (ø) ⬆️
src/BaseCharts/Line.js 100% <ø> (ø) ⬆️
src/BaseCharts/PolarArea.js 100% <ø> (ø) ⬆️
src/BaseCharts/Radar.js 100% <ø> (ø) ⬆️
src/BaseCharts/HorizontalBar.js 100% <ø> (ø) ⬆️
src/BaseCharts/Bar.js 100% <ø> (ø) ⬆️

@apertureless
Copy link
Owner

Thanks for this 🙏

@apertureless apertureless merged commit 71bcafa into apertureless:develop Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants