encoding/json does not compile

[kkoreilly]

failed to compile package encoding/json: failed to write declarations: failed to write function body: failed to write block statement: failed to write statement in block: failed to write assignment statement: failed to write argument: unhandled string conversion: string

This is a frequently used package, so fixing this would allow more programs to work.

[paralin]

@kkoreilly I think it might be better to override encoding/json within gs/ with a hand-written typescript package

The JSON encoder problem (heavy reflect usage) is something I have worked around by never using reflection / json encoder directly, see: https://github.com/aperturerobotics/protobuf-go-lite for example which generates JSON marshal/unmarshal code, along with https://github.com/aperturerobotics/json-iterator-lite

That said I know some code requires encoding/json with all the related functionality.

[kkoreilly]

@paralin Unfortunately we are highly dependent on reflect in Cogent Core; we have a package reflectx full of complex reflect logic we need for things like tables with value binding. We also depend on yaegi for interactive GUI code editing, which is highly dependent on reflection.

Basically, we will need full reflect support at some point. Do you have a sense of whether that is possible / how much work it will take?

[paralin]

There's already some reflect support, see: https://github.com/aperturerobotics/goscript/blob/master/compliance/tests/package_import_reflect/package_import_reflect.gs.ts#L74

I don't think it will be too hard to support the rest.

[kkoreilly]

Sounds good!

[paralin]

string(byte) is fixed and the compiler produces output for encoding/json

however, there remains issues with that output that are covered now by the package_import_encoding_json compliance test (known failing)

will continue to work on fixing those issues so it can eventually work correctly!