Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failure in multi-currency org #437

Closed
stohn777 opened this issue Dec 22, 2022 · 4 comments · Fixed by #438
Closed

Unit test failure in multi-currency org #437

stohn777 opened this issue Dec 22, 2022 · 4 comments · Fixed by #438
Assignees
Labels

Comments

@stohn777
Copy link
Contributor

Describe the bug

When deployed into an org having multi-currency enabled, the fflib_SObjectSelectorTest.testPolymorphicSelectWithRelatedType test fails with the exception "fflib_QueryFactory.InvalidFieldException: Invalid field 'CurrencyIsoCode' for object 'Group'".

To Reproduce

  1. Create a scratch org from the project's only definition file.
  2. In the org's Company Information, enable multi-currency.
  3. Push the source to the org.
  4. Run all tests.
  5. Note that all tests pass except for fflib_SObjectSelectorTest.testPolymorphicSelectWithRelatedType with the following exception.
fflib_QueryFactory.InvalidFieldException: Invalid field 'CurrencyIsoCode' for object 'Group'
Class.fflib_QueryFactory.getFieldPath: line 131, column 1
Class.fflib_QueryFactory.selectField: line 224, column 1
Class.fflib_SObjectSelector.configureQueryFactoryFields: line 388, column 1
Class.fflib_SObjectSelectorTest.testPolymorphicSelectWithRelatedType: line 486, column 1

Expected behavior
In a multi-currency org (as well as a single-currency org), all tests should pass.

Version
Latest version of master as of 2022-12-22 (commit: fbe6df4).

@szymon-halik
Copy link

I just encountered the same error once running the tests. Do we have any ETA when this will be fixed?

@stohn777
Copy link
Contributor Author

Hi @szymon-halik. Thanks for letting us know that you've experienced this issue too. A PR is waiting for approval from the other maintainers.
#438

@szymon-halik
Copy link

@stohn777 keeping fingers crossed for a quick code review 😉

@daveespo
Copy link
Contributor

Resolved in July 2023 via #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants