Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/unit test without dml #223

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Feature/unit test without dml #223

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4076f74
org independent test classes
wimvelzeboer Mar 3, 2020
ad8ad3a
Added Parallel unit testing
wimvelzeboer Mar 6, 2020
4aa6699
Merge branch 'master' into feature/UnitTestWithoutDML
wimvelzeboer Oct 8, 2021
e993494
Merge branch 'master' into feature/UnitTestWithoutDML
ImJohnMDaniel Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 28 additions & 143 deletions sfdx-source/apex-common/test/classes/fflib_QueryFactoryTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
**/

@isTest
@isTest( isParallel = true )
private class fflib_QueryFactoryTest {

@isTest
Expand Down Expand Up @@ -284,81 +284,37 @@ private class fflib_QueryFactoryTest {

@isTest
static void addChildQueriesWithChildRelationship_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
qf.selectField('name').selectField('Id').setCondition('name=\'test\'').addOrdering('CreatedDate', fflib_QueryFactory.SortOrder.DESCENDING, true);
Schema.DescribeSObjectResult descResult = Contact.SObjectType.getDescribe();
//explicitly assert object accessibility when creating the subselect
qf.subselectQuery('Tasks', true).selectField('Id').selectField('Subject').setCondition(' IsDeleted = false ');
List<fflib_QueryFactory> queries = qf.getSubselectQueries();
System.assert(queries != null);
List<Contact> contacts = Database.query(qf.toSOQL());
System.assert(contacts != null && contacts.size() == 1);
System.assert(contacts[0].Tasks.size() == 1);
System.assert(contacts[0].Tasks[0].Subject == 'test');
System.assert(
Pattern.matches('SELECT.*(SELECT.*FROM Tasks WHERE.*).*FROM Contact WHERE.*', qf.toSOQL()),
'Incorrect returned query'
);
}

@isTest
static void addChildQueriesWithChildRelationshipNoAccessibleCheck_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
qf.selectField('name').selectField('Id').setCondition('name=\'test\'').addOrdering('CreatedDate', fflib_QueryFactory.SortOrder.DESCENDING, true);
//explicitly assert object accessibility when creating the subselect
qf.subselectQuery('Tasks').selectField('Id').selectField('Subject').setCondition(' IsDeleted = false ');
List<fflib_QueryFactory> queries = qf.getSubselectQueries();
System.assert(queries != null);
String soql = qf.toSOQL();
System.debug(soql);
List<Contact> contacts = Database.query(soql);
System.assert(contacts != null && contacts.size() == 1);
System.assert(contacts[0].Tasks.size() == 1);
System.assert(contacts[0].Tasks[0].Subject == 'test');
System.assert(
Pattern.matches('SELECT.*(SELECT.*FROM Tasks WHERE.*).*FROM Contact WHERE.*', qf.toSOQL()),
'Incorrect returned query'
);
}

@isTest
static void addChildQueriesWithChildRelationshipObjCheckIsAccessible_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
qf.selectField('name').selectField('Id').setCondition('name=\'test\'').addOrdering('CreatedDate', fflib_QueryFactory.SortOrder.DESCENDING, true);
Schema.DescribeSObjectResult descResult = Contact.SObjectType.getDescribe();
Schema.ChildRelationship relationship;
for (Schema.ChildRelationship childRow : descResult.getChildRelationships()){
Expand All @@ -372,30 +328,16 @@ private class fflib_QueryFactoryTest {
qf.subselectQuery(relationship, true).selectField('Id').selectField('Subject').setCondition(' IsDeleted = false ');
List<fflib_QueryFactory> queries = qf.getSubselectQueries();
System.assert(queries != null);
List<Contact> contacts = Database.query(qf.toSOQL());
System.assert(contacts != null && contacts.size() == 1);
System.assert(contacts[0].Tasks.size() == 1);
System.assert(contacts[0].Tasks[0].Subject == 'test');
System.assert(
Pattern.matches('SELECT.*(SELECT.*FROM Tasks WHERE.*).*FROM Contact WHERE.*', qf.toSOQL()),
'Incorrect returned query'
);
}

@isTest
static void addChildQueriesWithChildRelationshipObj_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
qf.selectField('name').selectField('Id').setCondition( 'name=\'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
Schema.DescribeSObjectResult descResult = Contact.SObjectType.getDescribe();
Schema.ChildRelationship relationship;
for (Schema.ChildRelationship childRow : descResult.getChildRelationships()){
Expand All @@ -409,30 +351,16 @@ private class fflib_QueryFactoryTest {
qf.subselectQuery(relationship).selectField('Id').selectField('Subject').setCondition(' IsDeleted = false ');
List<fflib_QueryFactory> queries = qf.getSubselectQueries();
System.assert(queries != null);
List<Contact> contacts = Database.query(qf.toSOQL());
System.assert(contacts != null && contacts.size() == 1);
System.assert(contacts[0].Tasks.size() == 1);
System.assert(contacts[0].Tasks[0].Subject == 'test');
System.assert(
Pattern.matches('SELECT.*(SELECT.*FROM Tasks WHERE.*).*FROM Contact WHERE.*', qf.toSOQL()),
'Incorrect returned query'
);
}

@isTest
static void addChildQueriesWithChildRelationshipNoAccessibleCheck_fail(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
qf.selectField('name').selectField('Id').setCondition( 'name=\'test\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
Schema.DescribeSObjectResult descResult = Contact.SObjectType.getDescribe();
//explicitly assert object accessibility when creating the subselect
//
Expand All @@ -447,48 +375,21 @@ private class fflib_QueryFactoryTest {

@isTest
static void addChildQueries_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;

fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name').selectField('Id').setCondition( 'name like \'%test%\'' ).addOrdering('CreatedDate',fflib_QueryFactory.SortOrder.DESCENDING, true);
Schema.DescribeSObjectResult descResult = Contact.SObjectType.getDescribe();
//explicitly assert object accessibility when creating the subselect
qf.subselectQuery(Task.SObjectType, true).selectField('Id').selectField('Subject').setCondition(' IsDeleted = false ');
List<fflib_QueryFactory> queries = qf.getSubselectQueries();
System.assert(queries != null);
List<Contact> contacts = Database.query(qf.toSOQL());
System.assert(contacts != null && contacts.size() == 1);
System.assert(contacts[0].Tasks.size() == 1);
System.assert(contacts[0].Tasks[0].Subject == 'test');
System.assert(
Pattern.matches('SELECT.*(SELECT.*FROM Tasks WHERE.*).*FROM Contact WHERE.*', qf.toSOQL()),
'Incorrect returned query'
);
}

@isTest
static void addChildQuerySameRelationshipAgain_success(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
Task tsk = new Task();
tsk.WhoId = cont.Id;
tsk.Subject = 'test';
tsk.ActivityDate = System.today();
insert tsk;
fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name');
qf.selectField('Id');
Expand All @@ -514,14 +415,6 @@ private class fflib_QueryFactoryTest {

@isTest
static void addChildQueries_invalidChildRelationship(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name');
qf.selectField('email');
Expand All @@ -541,14 +434,6 @@ private class fflib_QueryFactoryTest {

@isTest
static void addChildQueries_invalidChildRelationshipTooDeep(){
Account acct = new Account();
acct.Name = 'testchildqueriesacct';
insert acct;
Contact cont = new Contact();
cont.FirstName = 'test';
cont.LastName = 'test';
cont.AccountId = acct.Id;
insert cont;
fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.selectField('name');
qf.selectField('email');
Expand All @@ -572,7 +457,7 @@ private class fflib_QueryFactoryTest {
static void checkFieldObjectReadSort_success(){
fflib_QueryFactory qf = new fflib_QueryFactory(Contact.SObjectType);
qf.assertIsAccessible()
.setEnforceFLS(true)
.setEnforceFLS(true)
.selectField('createdby.name')
.selectField(Contact.LastModifiedById)
.selectFields(new List<SObjectField>{Contact.LastModifiedDate})
Expand All @@ -585,7 +470,7 @@ private class fflib_QueryFactoryTest {
.addOrdering(new fflib_QueryFactory.Ordering('Contact','name',fflib_QueryFactory.SortOrder.ASCENDING) )
.addOrdering(Contact.LastModifiedDate,fflib_QueryFactory.SortOrder.DESCENDING)
.addOrdering(Contact.CreatedDate,fflib_QueryFactory.SortOrder.DESCENDING, true);
Set<String> fields = qf.getSelectedFields();
Set<String> fields = qf.getSelectedFields();
fflib_QueryFactory.Ordering ordering = new fflib_QueryFactory.Ordering('Contact','name',fflib_QueryFactory.SortOrder.ASCENDING);
System.assertEquals('Name',ordering.getField());

Expand Down