-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix: allow brush with rangeBars #4071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
approved these changes
Oct 27, 2023
@davidchateau I have merged this. |
This was referenced May 20, 2024
This was referenced May 26, 2024
This was referenced Jun 2, 2024
This was referenced Jun 17, 2024
This was referenced Jun 20, 2024
This was referenced Jun 28, 2024
This was referenced Jul 5, 2024
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
I believe it's currently not possible to use the 'brush' feature with rangeBars charts. JavaScript raises errors because the code attempts to read fields from null objects (e.g., w.globals.xAxisScale).
I have attempted to implement a clean and minimal fix, closely resembling the existing code. Each change is wrapped within an 'if (w.globals.isRangeBar)' condition to avoid interference with other features.
Fixes
I didn't file an issue, but someone raised the problem earlier this year: https://stackoverflow.com/questions/75618138/a-combination-of-two-rangebar-charts-in-apexcharts-but-brush-chart-does-not-work
Type of change
Checklist: