Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradient fill glitches for series with nulls. #4352

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Fix gradient fill glitches for series with nulls. #4352

merged 1 commit into from
Mar 23, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Mar 23, 2024 •
edited
Loading

Area and line paths must cover the full unbroken segment to render gradients correctly. Separate paths for each datapoint did not work.

Miscellaneous:

  1. Fix reference to stroke curve that assumed object would be a string (can also be an array).
  2. For completeness, add breaks to switch cases in getMinYMaxY(). Not having them was completely benign.

Fixes #1570
Fixes #4271
Fixes #3555

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@rosco54
Fix gradient fill glitches for series with nulls. The area path must
d9bff97 
cover the full unbroken segment to render correctly. Paths for each
datapoint did not work.

Miscellaneous:
1) Fix reference to stroke curve that assumed object would be a string
(can also be an array).
2) For completeness, add breaks to switch cases in getMinYMaxY().
Not having them was completely benign.
@rosco54 rosco54 marked this pull request as ready for review March 23, 2024 04:28
@junedchhipa junedchhipa merged commit 671c647 into apexcharts:main Mar 23, 2024
@rosco54 rosco54 deleted the Gradient_series_with_nulls_fix branch May 5, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedchhipa junedchhipa junedchhipa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rosco54 @junedchhipa