Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area path animation glitching issues #4452

Merged
merged 1 commit into from
May 4, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented May 4, 2024

Recent refactoring of line paths creation to fix various issues did not update the pathFromArea paths, upsetting animation morphing from those paths to final areaPaths.

  1. Remove redundant graphics.move() from end of lower rangeArea paths.
  2. Add closing line segment to pathFromArea path.

Fixes #4437

This has fixed the major issue but is still not perfect. There does appear to be an overall improvement visually over 3.45.2, the version preceeding the start of these refactoring efforts. If we compare, for example, the area-spline sample generated by 3.45.2 with that obtained after this patch, there is no longer a split between the line path and fill at every datapoint during the morphing process. There is instead a single artifact with the last datapoint that it would be nice to resolve.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Add closing line segment to pathFromArea path.
@rosco54 rosco54 marked this pull request as ready for review May 4, 2024 09:35
@junedchhipa junedchhipa merged commit ebaf1ee into apexcharts:main May 4, 2024
@rosco54 rosco54 deleted the Fill_glitches branch May 5, 2024 02:37
@AleksandrZhukov
Copy link

@rosco54 @junedchhipa
This commit creates glitch with gradient -

Screen.Recording.2024-05-14.at.09.11.53.mov

@rosco54 rosco54 mentioned this pull request May 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area Charts with Multiple Series Glitches Every Time on Animation using version 3.49.0
3 participants