Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore checks for single isolated data points #4716

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Sep 20, 2024

Remove unused variable (tidy-up, unrelated to the main issue)

Broken at revision 3.49.0:
Explicitly check for single isolated points when creating paths for 'straight' and 'smooth' curves. Curve type 'monotoneCubic' already does this intrinsically due to the different algorithm employed.

Fixes #4686

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

Issue 4686
Explicitly check for single isolated points when creating paths for
'straight' and 'smooth' curves. Curve type 'monotoneCubic' already
does this intrinsically due to the different algorithm employed.
@rosco54 rosco54 marked this pull request as ready for review September 20, 2024 13:06
@junedchhipa junedchhipa merged commit b3897ef into apexcharts:main Sep 20, 2024
7 checks passed
@rosco54 rosco54 deleted the Issue_4686 branch September 20, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

line graph goes blank for single point(weird behaviour)
2 participants