Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cap pip to 23 #46

Merged
merged 3 commits into from
Apr 20, 2023
Merged

chore: cap pip to 23 #46

merged 3 commits into from
Apr 20, 2023

Conversation

Thomzoy
Copy link
Collaborator

@Thomzoy Thomzoy commented Apr 20, 2023

Description

Since pip v23, some legacy install via setup.py fails (In our case pyspark).
This PR caps the pip version to avoid this issue.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch coverage: 36.56% and project coverage change: -8.09 ⚠️

Comparison is base (bbab536) 91.89% compared to head (2e0b427) 83.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   91.89%   83.80%   -8.09%     
==========================================
  Files          67       82      +15     
  Lines        2146     2488     +342     
==========================================
+ Hits         1972     2085     +113     
- Misses        174      403     +229     
Impacted Files Coverage Δ
eds_scikit/io/settings.py 100.00% <ø> (ø)
eds_scikit/phenotype/__init__.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/base.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/cancer/__init__.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/cancer/cancer.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/diabetes/__init__.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/diabetes/diabetes.py 0.00% <0.00%> (ø)
..._scikit/phenotype/psychiatric_disorder/__init__.py 0.00% <0.00%> (ø)
...otype/psychiatric_disorder/psychiatric_disorder.py 0.00% <0.00%> (ø)
eds_scikit/phenotype/suicide_attempt/__init__.py 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Thomzoy Thomzoy merged commit 24bf047 into main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants