Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools compatibility #48

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Tools compatibility #48

merged 3 commits into from
Sep 26, 2023

Conversation

Aremaki
Copy link
Collaborator

@Aremaki Aremaki commented Aug 3, 2023

Make the toole eds-scikit compatible with edsteva, edstoolbox and edsnlp

Description

Bump versions of altair and loguru

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@Aremaki Aremaki changed the title Bump altair and loguru versions Tools compatibility Aug 3, 2023
@Aremaki Aremaki requested a review from Thomzoy August 3, 2023 17:23
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (001fe9b) 83.84% compared to head (4694490) 83.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   83.84%   83.83%   -0.01%     
==========================================
  Files          82       82              
  Lines        2494     2493       -1     
==========================================
- Hits         2091     2090       -1     
  Misses        403      403              
Files Changed Coverage Δ
eds_scikit/io/hive.py 100.00% <ø> (ø)
eds_scikit/plot/age_pyramid.py 100.00% <ø> (ø)
eds_scikit/plot/event_sequences.py 100.00% <ø> (ø)
eds_scikit/biology/viz/plot.py 93.28% <100.00%> (-0.05%) ⬇️
eds_scikit/biology/viz/wrapper.py 85.29% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thomzoy
Copy link
Collaborator

Thomzoy commented Sep 21, 2023

Ok for me ! Deleting the csv and html files in Biology summary has no impact (ie in the doc) ?

@Aremaki
Copy link
Collaborator Author

Aremaki commented Sep 21, 2023

No, it is not use in the doc

@Aremaki Aremaki self-assigned this Sep 26, 2023
Copy link
Collaborator

@Thomzoy Thomzoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aremaki Aremaki merged commit ae8989a into main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants