Fix export_to_brat when there are spaces before new lines #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheooJ
force-pushed
the
pr-brat-connector
branch
from
121321d
to
7569fbd
Compare
percevalw
force-pushed
the
pr-brat-connector
branch
2 times, most recently
from
caaa603
to
7b31d99
Compare
percevalw
force-pushed
the
pr-brat-connector
branch
from
7b31d99
to
fbf4a86
Compare
percevalw
force-pushed
the
pr-brat-connector
branch
3 times, most recently
from
f265f6b
to
3cea06c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 246 246
Lines 6306 6293 -13
=======================================
- Hits 5947 5935 -12
+ Misses 359 358 -1
☔ View full report in Codecov by Sentry. |
percevalw
force-pushed
the
pr-brat-connector
branch
7 times, most recently
from
04c77fd
to
17ea5c6
Compare
percevalw
force-pushed
the
pr-brat-connector
branch
from
17ea5c6
to
4543c25
Compare
percevalw
force-pushed
the
pr-brat-connector
branch
from
25794f4
to
24d3cc1
Compare
percevalw
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
export_to_brathas been modified to allow the conversion of annotations detected on multiple lines, when there are spaces before newlines.Ex with the input text:
Before the change the output of
doc2bratwould have been:Which is not readable by brat because 1) the extra space before the newline is not accounted for, I remove it for counting spans and 2) the begin and end spans of the fragment on the newline were not incremented.
After the change it becomes:
Checklist