Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two features on EDS-TEVA #35

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Adding two features on EDS-TEVA #35

merged 8 commits into from
Nov 3, 2023

Conversation

svittoz
Copy link
Collaborator

@svittoz svittoz commented Oct 26, 2023

Adding two features on EDS-TEVA

Description

  • adding condition filtering on biology probe
  • adding condition_concept_codes parameter in condition probe to allow code filtering and by-codes predictors instead of by-concept_set predictors

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@svittoz svittoz requested review from Aremaki and Thomzoy November 2, 2023 09:50
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
edsteva/probes/biology/biology.py 100.00% <100.00%> (ø)
...biology/completeness_predictors/per_measurement.py 100.00% <ø> (ø)
...robes/biology/completeness_predictors/per_visit.py 97.05% <ø> (ø)
...condition/completeness_predictors/per_condition.py 100.00% <ø> (ø)
...bes/condition/completeness_predictors/per_visit.py 100.00% <ø> (ø)
edsteva/probes/condition/condition.py 100.00% <100.00%> (ø)
edsteva/probes/utils/prepare_df.py 99.32% <100.00%> (+<0.01%) ⬆️

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@Thomzoy Thomzoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! We should maybe add those features in the documentation ?

@Thomzoy Thomzoy removed the request for review from Aremaki November 3, 2023 14:49
@svittoz svittoz merged commit 24d3fc6 into main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants