Submission errors #366
Merged
Submission errors #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
feat/submission-errors
branch
from
e90832f to
437fbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a form (create or edit), submission errors (errors returned by the server) will be automatically displayed for the corresponding field.
It uses marmelab/react-admin#5778 and therefore will be only available for react-admin >= 3.12.
Validation errors don't follow a RFC or a convention, so it will only work if API Platform is used as the backend.
For other backends, the
schemaAnayzergetSubmissionErrorsmethod needs to be changed to map the submission errors correctly.An external library (final-form-submit-errors) is also used by default to clear the submit error when the related form field is changed.
This PR also adds missing props
SimpleFormandDatagridin guessers.