Skip to content

Commit

Permalink
attempt to skip behat ext deprec
Browse files Browse the repository at this point in the history
  • Loading branch information
soyuka committed Jun 3, 2024
1 parent 4811130 commit d782679
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
2 changes: 0 additions & 2 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
<server name="KERNEL_CLASS" value="AppKernel" />
<env name="APP_ENV" value="test" />
<env name="SYMFONY_PHPUNIT_REQUIRE" value="nikic/php-parser:^4.16"/>
<!-- to remove behat extensions in the AppKernel -->
<env name="APP_PHPUNIT" value="true"/>
</php>

<testsuites>
Expand Down
2 changes: 0 additions & 2 deletions phpunit10.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
<server name="KERNEL_DIR" value="tests/Fixtures/app/"/>
<server name="KERNEL_CLASS" value="AppKernel"/>
<env name="APP_ENV" value="test"/>
<!-- to remove behat extensions in the AppKernel -->
<env name="APP_PHPUNIT" value="true"/>
</php>

<testsuites>
Expand Down
2 changes: 2 additions & 0 deletions tests/.ignored-deprecations
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@
%The "Symfony\\Bundle\\MakerBundle\\Maker\\MakeAuthenticator" class is deprecated, use any of the Security\\Make\* commands instead%
# We don't care as we use this in our tests and the default value is just fine
%Since symfony/validator 7.1: Not passing a value for the "requireTld" option to the Url constraint is deprecated. Its default value will change to "true".%
# https://github.com/FriendsOfBehat/SymfonyExtension/pull/212
%The "Symfony\\Component\\HttpKernel\\DependencyInjection\\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\\Component\\DependencyInjection\\Extension\\Extension instead. It may change without further notice. You should not use it from "FriendsOfBehat\\SymfonyExtension\\Bundle\\DependencyInjection\\FriendsOfBehatSymfonyExtensionExtension".%
5 changes: 1 addition & 4 deletions tests/Fixtures/app/AppKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,11 @@ public function registerBundles(): array
new MercureBundle(),
new SecurityBundle(),
new WebProfilerBundle(),
new FriendsOfBehatSymfonyExtensionBundle(),
new FrameworkBundle(),
new MakerBundle(),
];

if (null === ($_ENV['APP_PHPUNIT'] ?? null)) {
$bundles[] = new FriendsOfBehatSymfonyExtensionBundle();
}

if (class_exists(DoctrineMongoDBBundle::class)) {
$bundles[] = new DoctrineMongoDBBundle();
}
Expand Down

0 comments on commit d782679

Please sign in to comment.