Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterEagerLoadingExtension dependency problem #2666

Closed
strider2038 opened this issue Mar 28, 2019 · 2 comments
Closed

FilterEagerLoadingExtension dependency problem #2666

strider2038 opened this issue Mar 28, 2019 · 2 comments
Labels
bug

Comments

@strider2038
Copy link

We have decorated class ResourceClassResolver in our project. After update to v2.4 we have issues with dependency injection of ResourceClassResolver in FilterEagerLoadingExtension

https://github.com/api-platform/core/blob/master/src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php#L35

I think it is good to use ResourceClassResolverInterface in FilterEagerLoadingExtension instead of conrete final class ResourceClassResolver.
@antograssiot
Copy link
Contributor

antograssiot commented Mar 28, 2019 •
edited
Loading

Indeed my bad, would you mind opening a PR ?
I can fix it tonight if not...

@soyuka soyuka added the bug label Mar 28, 2019
antograssiot added a commit to antograssiot/core that referenced this issue Mar 28, 2019
@antograssiot
Rely not interface not concrete implementation. closes api-platform#2666
679372f
antograssiot added a commit to antograssiot/core that referenced this issue Mar 28, 2019
@antograssiot
Rely on interface not concrete implementation in DI. closes api-platf…
8601499 
…orm#2666
antograssiot added a commit to antograssiot/core that referenced this issue Mar 28, 2019
@antograssiot
Rely on interface not concrete implementation in constructor. closes a…
cda29f7 
…pi-platform#2666
@antograssiot antograssiot mentioned this issue Mar 28, 2019
Merged
@antograssiot
Copy link
Contributor

Closing as there is an open PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soyuka @antograssiot @strider2038