[GraphQL] Fix introspection (graphql-php / GraphiQL) #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
fix/introspection-custom-types
branch
from
311525d to
2b64eaa
Compare
|
Can you just remove the code for now please ( |
alanpoulain
force-pushed
the
fix/introspection-custom-types
branch
from
28b5ef2 to
d317e94
Compare
|
This is done. |
Simperfit
approved these changes
May 2, 2018
|
Thanks @alanpoulain. |
teohhanhui
pushed a commit
to teohhanhui/api-platform-core
that referenced
this pull request
May 2, 2018
…on-custom-types [GraphQL] Fix introspection (graphql-php / GraphiQL)
19 tasks
1 task
|
@alanpoulain, please inform current status concerning embedded mutations. I have a bid entity which embeds a message entity, which embeds an attachment entity. As it is now, it seems that I need to create 3 create mutations. Is that still the case? Thanks. |
|
Yes it is: #3258 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best way to fix current issues with GraphQL introspection is to remove the problematic code.
We should be waiting for this PR to be merged graphql/graphql-spec#395 and changes to be affected to graphql-php and graphql-js in order to add it again.
The main lost feature is the ability to manage embedded entities.
A way to get this feature back will be to have two fields (one for an IRI, the other for the data) for relations but there is some work to be done.