Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow POST/DELETE on an ApiSubresource #2428

Closed
wants to merge 1 commit into from
Closed

[WIP] Allow POST/DELETE on an ApiSubresource #2428

wants to merge 1 commit into from

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Dec 28, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1628
License MIT
Doc PR TODO
Dependencies #2706
  • Update routing to add POST & DELETE methods
  • In POST request, add data to root object collection (ie: $rootData->addRelatedDummy($data))
  • In DELETE request, remove data from root object collection (ie: $rootData->removeRelatedDummy($data))
  • Add ApiSubresource annotation option to enable/disable POST/DELETE operations
  • Add Behat tests
  • Add PHPUnit tests
  • Add documentation PR (if the workflow of this one is validated by the core team)

@vincentchalamon vincentchalamon self-assigned this Dec 28, 2018
@soyuka
Copy link
Member

soyuka commented Apr 4, 2019

Related: #2598

@vincentchalamon vincentchalamon force-pushed the feature/subresource-write branch 2 times, most recently from f8b740b to 18bcf90 Compare April 5, 2019 11:58
@alanpoulain alanpoulain mentioned this pull request Apr 6, 2019
Closed
22 tasks
@vincentchalamon vincentchalamon force-pushed the feature/subresource-write branch 3 times, most recently from 1566d69 to 69c5e4b Compare April 6, 2019 18:20
@torreytsui torreytsui mentioned this pull request Apr 6, 2019
Closed
@soyuka soyuka mentioned this pull request Apr 7, 2019
Closed
4 tasks
@vincentchalamon vincentchalamon force-pushed the feature/subresource-write branch 2 times, most recently from 93cfaf1 to 7b66308 Compare April 8, 2019 15:30
@vincentchalamon vincentchalamon force-pushed the feature/subresource-write branch from 7b66308 to 5a5cdd2 Compare April 8, 2019 15:56
@flug
Copy link
Contributor

flug commented Nov 14, 2019

@vincentchalamon Up is this pull request still valid? @soyuka

@vincentchalamon
Copy link
Contributor Author

@flug Not really... Waiting for #2706

@vincentchalamon vincentchalamon deleted the feature/subresource-write branch June 11, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vincentchalamon vincentchalamon

Labels
enhancement ⭐ EU-FOSSA Hackathon [WIP] Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentchalamon @soyuka @flug