bugfix-2838-searchfilter-custom-types #2873
Conversation
…stom types in the ORM SearchFilter.
|
The test failure looks related to this patch. Could you try to fix the code? |
will do |
|
Any idea when this is going to be available? |
|
Terribly sorry guys, I haven't had the time to come back to this. Can someone pick this up please and fix the tests? Thanks. |
|
Any ETA or docs fix about this, because it is not documented that custom type ids are not supported in filters? |
| } | ||
|
|
||
| /** | ||
| * Adds where clause according to the strategy. | ||
| * | ||
| * @throws InvalidArgumentException If strategy does not exist | ||
| */ | ||
| protected function addWhereByStrategy(string $strategy, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $alias, string $field, $value, bool $caseSensitive) | ||
| protected function addWhereByStrategy(string $strategy, QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $alias, string $field, $value, bool $caseSensitive, $doctrineType) |
There was a problem hiding this comment.
BC: we cannot add a non-optional argument to a protected class method.
| } | ||
| } | ||
|
|
||
| private function setOrClause(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, array $values, $alias, $field, $doctrineType, $caseSensitive) |
There was a problem hiding this comment.
Note: This method should be removed.
| { | ||
| $wrapCase = $this->createWrapCase($caseSensitive); | ||
| $orX = $queryBuilder->expr()->orX(); | ||
| foreach ($values as $value) { |
There was a problem hiding this comment.
We should avoid dynamic queries like this.
|
Hello, was it fixed on released brand or isn't fixed yet? Thanks 🙏 |
|
It would be cool to get this in. Any help needed? |
Added support for doctrine types in ORM SearchFilter.