Fix symfony 4.4 compat #3285
Merged
Fix symfony 4.4 compat #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ErrorListener may be remvoved from the container if deprecated configuration is used. We must use the deprecated Exception listener if so. https://github.com/symfony/symfony/blob/bfae515d521a421b413cb39e8fae727ffb4ca28b/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExceptionListenerPass.php#L37
|
btw, users can fix this themselves by not using a deprecated twig configuration: |
dunglas
reviewed
Nov 22, 2019
| { | ||
| if (class_exists(ErrorListener::class)) { | ||
| if (null !== $errorListener) { |
There was a problem hiding this comment.
Could you invert the test (test for === null)
dunglas
approved these changes
Nov 22, 2019
|
I have no idea why that |
|
It's not required, don't worry. |
maxhelias
approved these changes
Nov 22, 2019
|
It's because FOSUser isn't compatible with Symfony 4.4 yet. |
|
Thanks @bendavies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If is not enough to check for the existence of
Symfony\Component\HttpKernel\EventListener\ErrorListenerto know if we can use it or not on symfony 4.4.It may have been removed from the container.
The new ErrorListener is functionally different to the deprecated one, as the new one flattens exceptions with the KernelEvents::CONTROLLER_ARGUMENTS event, and not when the attributes are added.
If
ErrorListeneris removed from the container, the exception will never be converted to a flattened exception, causing the wrong Exception type to be passed to the ExceptionAction.