fix(ulid): convert Ulid object to binary for ORM search filter #4313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want filter a resource by a relation property defined by an Ulid identifier, it doesn't work. This PR adds the conversion to binary before calling the query builder of Doctrine (as explained on the Symfony documentation: https://symfony.com/doc/current/components/uid.html#storing-ulids-in-databases).
Example:
Currently, the result is 0 because the query builder uses the string representation that does not correspond to the binary stored in the database.
It is my first contribution. I don't know if I have to add a test for it and how, and I don't know if I have to change the Changelog file right now.
Don't hesitate to help me to improve this PR 🙂