Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the non-legacy code to src #4556

Merged
merged 34 commits into from
Nov 18, 2021
Merged

Move the non-legacy code to src #4556

merged 34 commits into from
Nov 18, 2021

Conversation

laryjulien
Copy link
Contributor

Q A
Branch? main
Tickets #4548
License MIT
Doc PR To be completed

@laryjulien laryjulien mentioned this pull request Nov 10, 2021
Closed
@laryjulien laryjulien changed the title Refactor core remove core namespace Move the non-legacy code to src Nov 10, 2021
@laryjulien laryjulien mentioned this pull request Nov 10, 2021
Closed
@laryjulien laryjulien marked this pull request as draft November 10, 2021 13:13
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from 4c070b0 to db761b0 Compare November 10, 2021 16:47
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from db761b0 to f5929a5 Compare November 10, 2021 16:54
kaznovac
kaznovac reviewed Nov 11, 2021
View reviewed changes
Copy link

@kaznovac kaznovac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr should address file move and namespace changes.

the formatting changes (if necessary) should be suggested as part of a separate pr.

@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from 00af99e to 823dd64 Compare November 12, 2021 13:42
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from 823dd64 to 8732bc9 Compare November 12, 2021 13:56
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from bbc5663 to 498e15f Compare November 14, 2021 22:11
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from 498e15f to 1105bc3 Compare November 15, 2021 10:34
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from ba870c6 to 62c6702 Compare November 15, 2021 14:20
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch 2 times, most recently from 540ab12 to 6b82afb Compare November 15, 2021 16:16
@laryjulien laryjulien force-pushed the refactor-core-remove-core-namespace branch from 6b82afb to b98908c Compare November 15, 2021 16:28
@laryjulien
Copy link
Contributor Author

FQCN (fully qualified class name) are not updated in CHANGELOG.md

@laryjulien laryjulien mentioned this pull request Nov 17, 2021
Merged
@soyuka soyuka marked this pull request as ready for review November 18, 2021 15:04
@soyuka soyuka merged commit 10827bb into api-platform:main Nov 18, 2021
@soyuka
Copy link
Member

soyuka commented Nov 18, 2021

Huge work thank you very much @laryjulien @kevin-verschaeve @GrimpEreau @FloVnst !

@robertfausk robertfausk mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaznovac kaznovac kaznovac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laryjulien @soyuka @kaznovac @GrimpEreau