-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Symfony IriConverter with item_uri_template
#5663
Conversation
vincentchalamon
commented
Jul 11, 2023
Q | A |
---|---|
Branch? | 3.1 |
Tickets | #5662 |
License | MIT |
Doc PR | N/A |
item_uri_template
b6c9b38
to
6184687
Compare
cf3c11b
to
a3ee9b3
Compare
Works for me - thanks Vincent and Antoine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove that last parameter if you removed it alltogether?
private function generateSymfonyRoute(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, Operation $operation = null, array $context = [], **Operation $identifiersExtractorOperation = null**): string
IIRC I did this because of huge performance improvements on item IRI generation, should we try to profile this to check for a change in performance on these code paths?
a3ee9b3
to
7690b1d
Compare
I did some cleanup and improved the patch a bit can you look at my commit (was based on your branch, rebased on 3.1) /edit: I need to check the CI |
7690b1d
to
72a2c71
Compare
I need to investigate your commit on api-platform/demo to ensure it still fixes my original bug. |
@soyuka this new version of the code does not work on api-platform/demo (cf. api-platform/demo#327) |
f18941e
to
60b9c1a
Compare
60b9c1a
to
8f9fedb
Compare
8f9fedb
to
4b8a3ce
Compare