Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symfony IriConverter with item_uri_template #5663

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

vincentchalamon
Copy link
Contributor

Q A
Branch? 3.1
Tickets #5662
License MIT
Doc PR N/A

@vincentchalamon vincentchalamon requested a review from soyuka July 11, 2023 18:01
@vincentchalamon vincentchalamon self-assigned this Jul 11, 2023
@vincentchalamon vincentchalamon changed the title fix(api): fix Symfony IriConverter with item_uri_template Fix Symfony IriConverter with item_uri_template Jul 11, 2023
@vincentchalamon vincentchalamon changed the title Fix Symfony IriConverter with item_uri_template Fix Symfony IriConverter with item_uri_template Jul 11, 2023
@vincentchalamon vincentchalamon force-pushed the fix/issues/5662 branch 3 times, most recently from b6c9b38 to 6184687 Compare July 11, 2023 18:23
@vincentchalamon vincentchalamon marked this pull request as draft July 11, 2023 18:29
@vincentchalamon vincentchalamon removed the request for review from soyuka July 11, 2023 18:29
@vincentchalamon vincentchalamon force-pushed the fix/issues/5662 branch 3 times, most recently from cf3c11b to a3ee9b3 Compare July 20, 2023 14:29
@vincentchalamon vincentchalamon marked this pull request as ready for review July 25, 2023 07:06
@vincentchalamon vincentchalamon requested a review from soyuka July 25, 2023 07:06
@paullallier
Copy link
Contributor

Works for me - thanks Vincent and Antoine.

Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove that last parameter if you removed it alltogether?

    private function generateSymfonyRoute(object|string $resource, int $referenceType = UrlGeneratorInterface::ABS_PATH, Operation $operation = null, array $context = [], **Operation $identifiersExtractorOperation = null**): string

IIRC I did this because of huge performance improvements on item IRI generation, should we try to profile this to check for a change in performance on these code paths?

@soyuka
Copy link
Member

soyuka commented Aug 14, 2023

vincentchalamon@72a2c71

I did some cleanup and improved the patch a bit can you look at my commit (was based on your branch, rebased on 3.1)

/edit: I need to check the CI

@vincentchalamon
Copy link
Contributor Author

vincentchalamon@72a2c71

I did some cleanup and improved the patch a bit can you look at my commit (was based on your branch, rebased on 3.1)

/edit: I need to check the CI

I need to investigate your commit on api-platform/demo to ensure it still fixes my original bug.

@vincentchalamon
Copy link
Contributor Author

@soyuka this new version of the code does not work on api-platform/demo (cf. api-platform/demo#327)

@soyuka soyuka force-pushed the fix/issues/5662 branch 2 times, most recently from f18941e to 60b9c1a Compare August 21, 2023 20:07
@soyuka soyuka merged commit e3e6a0d into api-platform:3.1 Aug 22, 2023
@vincentchalamon vincentchalamon deleted the fix/issues/5662 branch August 22, 2023 13:28
Rainrider added a commit to Rainrider/api-platform-ms-bundle that referenced this pull request Dec 16, 2024
Rainrider added a commit to Rainrider/api-platform-ms-bundle that referenced this pull request Dec 16, 2024
Rainrider added a commit to Rainrider/api-platform-ms-bundle that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid IRI generation when using GetCollection::itemUriTemplate and multiple identifiers
3 participants